Development: Reuse compliance analysis across languages via snippet mapping - #2470

Reviewed on top of Cathy's existing review — none of the points below overlap with hers.

The core idea is right: snippet mapping instead of a second full-text analysis is exactly the lever worth pulling here, and applyJobChangeForAnalysis quietly adds the first ownership check on this path — updateAiAnalysis had none on main. Raw List → List<ComplianceIssue> is a good catch too.

The prompt rewrite that ships with it is broken, though.

Blocking

1. {format} breaks every compliance analysis (AnalyzeComplianceText.st:59) — unresolved template variable, StTemplateRenderer defaults to ValidationMode.THROW. Reproduced against the real Spring AI 2.0.0-M4 jars; details inline.

2. Output contract no longer matches ComplianceIssue (AnalyzeComplianceText.st:52) — the prompt asks for text, category, suggestion, but there is no suggestion field anywhere in the project, and article / explanation / action are no longer requested at all. The compliance popover renders nothing but article and explanation.

3. {userLang} silently dropped (AnalyzeComplianceText.st:9) — the parameter is still passed from client through resource to service, and the JavaDoc still promises it controls the explanation language. It no longer does anything.

4. jobId has no Bean Validation (MapComplianceIssuesRequestDTO.java:13) — a request without it runs the LLM mapping, returns 200, and persists nothing without any error or log.

A general note on 1–3: the prompt rewrite looks unrelated to "reuse compliance analysis across languages via snippet mapping". Splitting it into its own PR would have surfaced these — the mapping logic itself is sound.

Test coverage

62be17d06 "removed tests" deletes AiServiceTest.java (418 lines) including five tests for mapComplianceIssues, with no resource-level replacement. That follows the no-*ServiceTest rule, but it leaves the empty-source-issues early return, the LLM catch branch, the size/null mismatch branch, and — most importantly — the silent dropping of non-verbatim snippets (continue after SnippetMatcher.isVerbatim) completely uncovered. SnippetMatcherTest only covers the trivial helper.

Things I checked and found fine

Listing these so they don't come up in a later round:

• LLM call before the ownership check in mapComplianceIssues — consistent with analyzeJobDescription and extractPdfData, and this PR improves the situation rather than worsening it. isAdminOrMemberOf returns void and throws AccessDeniedException, so nothing is being silently ignored.
• let finalContent: string | null = null — the type is forced by the pre-existing extractTranslatedTextFromStream(): string | null; no lint rule against null, and it appears in 77 of 267 client files.
• The if (!jobId) return moved to the top of translateAndStoreOtherLanguage — both callers run after an awaited saveDraft with no await in between, so it is unreachable defence, not a behaviour change.
• void-ed analysis promise in processDescriptionWithAi — analyzeAndUpdateScore has nothing throwable outside its try, and main had the same shape with void Promise.all([...]).
• Fully-qualified java.util.stream.IntStream — 19 comparable spots in src/main/java, no checkstyle or Spotless gate on imports.
• postAndRead(..., Void.class, 400) without assertThat — postInvalid asserts the status itself; 81 test methods in the repo do it this way.
• toHaveBeenCalledWith instead of toHaveBeenCalledOnce — the rule targets call-count assertions; 468 of 546 toHaveBeenCalledWith in the repo carry no count assertion.